Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform into a module and make coherent with Ecosystem #1

Merged
merged 13 commits into from
Aug 19, 2023

Conversation

mickahell
Copy link
Contributor

@mickahell mickahell commented Aug 18, 2023

Summary

Make the project a python project to make coherent with the Qiskit Ecosystem.
I transform your project into a Python module.

Now it can be launch using fire by simply launch from root of the repo :

python quantum_glasses.py

Also the unittests can be launch using :

tox -epy39

Also I clean your requirements file, and add the package fire and tox.

After merging this PR you would be available to add your project to Ecosystem.

Details

  • Add setup.py
  • Add tox.ini
  • Add CI testing
  • Update tests
  • Clean requirements
  • Structure its as object
  • Update README.md
  • Test Ecosystem integration run

Related Qiskit/ecosystem#478

@mickahell mickahell changed the title Transform into a module Transform into a module and make coherent with Ecosystem Aug 18, 2023
@mickahell mickahell marked this pull request as draft August 18, 2023 19:07
@mickahell mickahell marked this pull request as ready for review August 18, 2023 19:15
@Jayshah25 Jayshah25 merged commit 1885672 into Jayshah25:main Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants